Remove internal Profiler in favour of Tracy #2266
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to remove the internal profiler since it had some hard to fix flaws:
.conf()
in Python) in examples to print the resultsmechanism.hpp
Tracy on the other hand gives us
all in 3 macros.
I have some plans to add memory tracking later on, but I am reluctant to overload
new
and thatseems to be the only way of getting into
std::vector
and friends.Here's the moment when we add spikes:
Some clean-up was done as well, mainly swapping
std::shared_ptr{new T(...)}
forstd::make_shared<T>(...)
and same for
unique_ptr
.