Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump web3modal from 4.2.3 to 5.1.11 #121

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

gbonumore
Copy link
Contributor

@gbonumore gbonumore commented Nov 20, 2024

Updated web3modal to v5 and hid the onramp option.

Copy link

linear bot commented Nov 20, 2024

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@xavikh xavikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavikh
Copy link
Contributor

xavikh commented Nov 27, 2024

Screenshot 2024-11-27 at 8 38 33 AM

I don't think is related to this changes but it seems the wallet component is not showing the avatar

@gbonumore
Copy link
Contributor Author

Screenshot 2024-11-27 at 8 38 33 AM I don't think is related to this changes but it seems the wallet component is not showing the avatar

Definitely out of scope on this PR but nice spotting, can you add that to the linear project so we keep track of this?

@carlosgj94 carlosgj94 merged commit 1e7db96 into main Dec 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants