Merge pull request #183 from romanseidl/patch-1

Fix regression: `did-get-response-details` no longer functional in Electron 3
arachnys · Dec 6, 2018 · b201a6d · b201a6d
2 parents 77d311a + 179275f
commit b201a6d
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/cli/src/athenapdf.js b/cli/src/athenapdf.js
@@ -218,12 +218,10 @@ app.on("ready", () => {
         }
     });
 
-    bw.webContents.on("did-get-response-details", (e, status, newURL, originalURL, httpResponseCode, requestMethod, referrer, headers, resourceType) => {
+    bw.webContents.on("did-navigate", (e, newURL, httpResponseCode, httpResponseText) => {
         if (httpResponseCode >= 400) {
             console.error(`Failed to load ${newURL} - got HTTP code ${httpResponseCode}`);
-            if (resourceType === "mainFrame") {
-                app.exit(1);
-            }
+            app.exit(1);
         }
     });