Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sxyazi/yazi): use musl build on linux where available #31275

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

scop
Copy link
Contributor

@scop scop commented Jan 23, 2025

Check List

musl build is available in >= 0.2.4.

@suzuki-shunsuke
Copy link
Member

Thank you.
Just curious.
You fixed some tools, but how did you find these fixes?
Did you use these tools and face any issues?

@suzuki-shunsuke suzuki-shunsuke added this to the v4.300.1 milestone Jan 23, 2025
@suzuki-shunsuke suzuki-shunsuke merged commit 72682cd into aquaproj:main Jan 23, 2025
17 checks passed
@scop scop deleted the refactor/sxyazi-yazi-musl branch January 23, 2025 14:51
@scop
Copy link
Contributor Author

scop commented Jan 23, 2025

I used dprint/dprint on Alpine and ran into these issues with it.

I fixed it and decided to look for others that might have the same problem, using a rather dumb, low tech approach:

  1. git grep linux-gnu pkgs | cut -d: -f 1 | uniq > TODO-linux-gnu.txt, then go through each file found,
  2. First look at the registry.yaml snippet to see if latest version is already using musl or otherwise static build. If yes, don't look into it further. If not,
  3. Look into the project's releases to see if the latest has a musl/static Linux build available. If yes, take a look at fixing it.

I'm currently midway through in doing 2. above over the full list, and have fixed a few here and there that I had gone through. I can post the list that remains after going through the above process before starting to fix any more of them to an issue if you like.

@scop
Copy link
Contributor Author

scop commented Jan 23, 2025

List up at #31296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants