Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(int128/ghcp): re-scaffold int128/ghcp #30298

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

kyontan
Copy link
Contributor

@kyontan kyontan commented Dec 24, 2024

int128/ghcp supported multiple architecture after v1.13.1 but the aqua-registry still pointed to amd64 binary.

(This caused https://github.com/suzuki-shunsuke/tfaction not working in arm64 environment)

Ref:

@kyontan kyontan changed the title feat(int128/ghcp): scaffold int128/ghcp feat(int128/ghcp): re-scaffold int128/ghcp Dec 24, 2024
@kyontan kyontan marked this pull request as ready for review December 24, 2024 08:21
@suzuki-shunsuke
Copy link
Member

Thank you for your contribution!

@suzuki-shunsuke suzuki-shunsuke added this to the v4.284.0 milestone Dec 24, 2024
@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Dec 24, 2024

Your commit isn't signed.
Could you sign commits according to the guide?
https://aquaproj.github.io/docs/products/aqua-registry/contributing/#commit-signing
https://github.com/suzuki-shunsuke/oss-contribution-guide/blob/main/docs/commit-signing.md

Merging is blocked
The base branch requires all commits to be signed. Learn more about signing commits.

image

@suzuki-shunsuke suzuki-shunsuke removed this from the v4.284.0 milestone Dec 24, 2024
@suzuki-shunsuke
Copy link
Member

I want to accept your pr, but If you can't sign commits, I'll create a pull request instead of you.
Thank you.

@suzuki-shunsuke
Copy link
Member

(This caused https://github.com/suzuki-shunsuke/tfaction not working in arm64 environment)

As a workaround, my fork suzuki-shunsuke/ghcp is available.

https://github.com/suzuki-shunsuke/ghcp

This comment was marked as resolved.

@kyontan
Copy link
Contributor Author

kyontan commented Dec 25, 2024

@suzuki-shunsuke Hi, I just signed my commit and re-pushed. could you review this again?

@suzuki-shunsuke suzuki-shunsuke added this to the v4.284.1 milestone Dec 25, 2024
@suzuki-shunsuke suzuki-shunsuke merged commit d321861 into aquaproj:main Dec 25, 2024
17 checks passed
@suzuki-shunsuke
Copy link
Member

Thank you.

@suzuki-shunsuke
Copy link
Member

🎉 https://github.com/aquaproj/aqua-registry/releases/tag/v4.284.1

@kyontan kyontan deleted the feat/int128/ghcp branch December 25, 2024 06:40
@kyontan
Copy link
Contributor Author

kyontan commented Dec 25, 2024

@suzuki-shunsuke Thanks!

Could you also update aqua-checksums.json to include ghcp variant of linux_arm64?
https://github.com/suzuki-shunsuke/tfaction/blob/cb5972bc25678c8be69bcd35efea406520353eaa/aqua-checksums.json#L48-L62

@suzuki-shunsuke
Copy link
Member

Sure.

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Dec 25, 2024

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Dec 28, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [aquaproj/aqua-registry](https://github.com/aquaproj/aqua-registry) | minor | `v4.282.0` -> `v4.285.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>aquaproj/aqua-registry (aquaproj/aqua-registry)</summary>

### [`v4.285.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.285.0)

[Compare Source](aquaproj/aqua-registry@v4.284.2...v4.285.0)

[Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.285.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.285.0) | aquaproj/aqua-registry@v4.284.2...v4.285.0

#### 🎉 New Packages

[#&#8203;30387](aquaproj/aqua-registry#30387) [suzuki-shunsuke/rjsa](https://github.com/suzuki-shunsuke/rjsa): A command to release JavaScript action

### [`v4.284.2`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.284.2)

[Compare Source](aquaproj/aqua-registry@v4.284.1...v4.284.2)

[Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.284.2) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.284.2) | aquaproj/aqua-registry@v4.284.1...v4.284.2

#### Fixes

[#&#8203;30355](aquaproj/aqua-registry#30355) gradle/gradle-distributions: Migrate gradle/gradle to gradle/distributions
[#&#8203;30334](aquaproj/aqua-registry#30334) rust-lang/rust-analyzer: Use gnu instead of musl target env [@&#8203;NavyD](https://github.com/NavyD)
[#&#8203;30321](aquaproj/aqua-registry#30321) aptly-dev/aptly: Re-scaffold settings
[#&#8203;30320](aquaproj/aqua-registry#30320) goark/depm: Re-scaffold goark/depm

### [`v4.284.1`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.284.1)

[Compare Source](aquaproj/aqua-registry@v4.284.0...v4.284.1)

[Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.284.1) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.284.1) | aquaproj/aqua-registry@v4.284.0...v4.284.1

#### Fixes

[#&#8203;30298](aquaproj/aqua-registry#30298) int128/ghcp: Re-scaffold int128/ghcp [@&#8203;kyontan](https://github.com/kyontan)

### [`v4.284.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.284.0)

[Compare Source](aquaproj/aqua-registry@v4.283.0...v4.284.0)

[Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.284.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.284.0) | aquaproj/aqua-registry@v4.283.0...v4.284.0

#### 🎉 New Packages

[#&#8203;30256](aquaproj/aqua-registry#30256) [shini4i/argo-compare](https://github.com/shini4i/argo-compare): A comparison tool for displaying the differences between ArgoCD Applications in different Git branches
[#&#8203;30316](aquaproj/aqua-registry#30316) [suzuki-shunsuke/disable-checkout-persist-credentials](https://github.com/suzuki-shunsuke/disable-checkout-persist-credentials): CLI to disable actions/checkout's persist-credentials
[#&#8203;30314](aquaproj/aqua-registry#30314) [xo/xo](https://github.com/xo/xo): xo is a command-line tool to generate idiomatic code for different languages code based on a database schema or a custom query [@&#8203;nnaakkaaii](https://github.com/nnaakkaaii)

#### Fixes

[#&#8203;30303](aquaproj/aqua-registry#30303) future-architect/tftarget: Regenerate the setting

### [`v4.283.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.283.0)

[Compare Source](aquaproj/aqua-registry@v4.282.0...v4.283.0)

[Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.283.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.283.0) | aquaproj/aqua-registry@v4.282.0...v4.283.0

#### 🎉 New Packages

[#&#8203;30240](aquaproj/aqua-registry#30240) [GoogleCloudPlatform/alloydb-auth-proxy](https://github.com/GoogleCloudPlatform/alloydb-auth-proxy) - A utility for connecting securely to your AlloyDB instances [@&#8203;yanolab](https://github.com/yanolab)
[#&#8203;30254](aquaproj/aqua-registry#30254) [fujiwara/kinesis-tailf](https://github.com/fujiwara/kinesis-tailf): tail -f command for Amazon Kinesis Stream

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS44MC4wIiwidXBkYXRlZEluVmVyIjoiMzkuODMuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants