Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deny unprivileged users from setting "k8s.cloudscale.ch/loadbalancer-uuid" #106

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Deny unprivileged users from setting "k8s.cloudscale.ch/loadbalancer-uuid" #106

merged 1 commit into from
Jul 26, 2024

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Jul 25, 2024

See https://ticket.vshn.net/browse/APUB-669

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@bastjan bastjan added the enhancement New feature or request label Jul 25, 2024
@bastjan bastjan force-pushed the validate-cloudscale-uuid-annotation branch from 8c49c71 to 5ccbb02 Compare July 25, 2024 15:05
@bastjan bastjan marked this pull request as ready for review July 25, 2024 15:06
@bastjan bastjan requested a review from a team as a code owner July 25, 2024 15:06
simu
simu approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bastjan bastjan merged commit 5398c08 into master Jul 26, 2024
4 checks passed
@bastjan bastjan deleted the validate-cloudscale-uuid-annotation branch July 26, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastjan @simu