Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #105

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Update dependencies #105

merged 1 commit into from
Jul 25, 2024

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Jul 24, 2024

Summary

  • The Watches...() methods of the controller builder are now typed.
  • admission.Decoder might have changed from a struct to an interface. Did not check against the old version but it is an interface now.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.

@bastjan bastjan requested a review from a team as a code owner July 24, 2024 14:55
The `Watches...()` methods of the controller builder are now typed.
`admission.Decoder` might have changed from a struct to an interface. Did not check against the old version but it is an interface now.
Copy link

@HappyTetrahedron HappyTetrahedron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That checks out

@bastjan bastjan merged commit 1d75410 into master Jul 25, 2024
4 checks passed
@bastjan bastjan deleted the update-deps branch July 25, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants