-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: SSH key dropdown scrolls with modal #38584
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
/build-deploy-preview |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12710306742. |
Deploy-Preview-URL: https://ce-38584.dp.appsmith.com |
Description
This changes the dropdown container to fix overflow issues in the Git connect/import modal. The SSH key dropdown now properly scrolls with the modal content instead of remaining fixed in place.
Type of Change
How Has This Been Tested?
Link to Devin run: https://app.devin.ai/sessions/be239c326a7149eaaefe6f6c39d58470
Automation
/test sanity
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12710679010
Commit: 40cdbf4
Cypress dashboard.
Tags:
@tag.Sanity
Spec:
Fri, 10 Jan 2025 14:28:55 UTC