Skip to content

Commit

Permalink
Use CNB builder for heroku-22 stack
Browse files Browse the repository at this point in the history
refs #5
  • Loading branch information
ipmb committed Oct 30, 2023
1 parent f96edcb commit 8f1bad6
Showing 1 changed file with 16 additions and 9 deletions.
25 changes: 16 additions & 9 deletions builder/build/appjson.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,18 @@ const DefaultStack = "heroku-20"
var IncludedBuildpacks = map[string][]string{
"heroku-20": {
// $ pack builder inspect heroku/buildpacks:20 -o json | jq '.remote_info.buildpacks[].id'
"heroku/builder-eol-warning",
"heroku/go",
"heroku/gradle",
"heroku/java",
"heroku/java-function",
"heroku/jvm",
"heroku/jvm-function-invoker",
"heroku/maven",
"heroku/nodejs",
"heroku/nodejs-corepack",
"heroku/nodejs-engine",
"heroku/nodejs-function",
"heroku/nodejs-function-invoker",
"heroku/nodejs-npm",
"heroku/nodejs-npm-engine",
"heroku/nodejs-npm-install",
"heroku/nodejs-pnpm-install",
"heroku/nodejs-yarn",
"heroku/php",
"heroku/procfile",
Expand All @@ -53,16 +53,24 @@ var IncludedBuildpacks = map[string][]string{
"heroku/scala",
},
"heroku-22": {
// $ pack builder inspect heroku/builder-classic:22 -o json | jq '.remote_info.buildpacks[].id'
"heroku/clojure",
// $ pack builder inspect heroku/builder:22 -o json | jq '.remote_info.buildpacks[].id'
"heroku/go",
"heroku/gradle",
"heroku/java",
"heroku/jvm",
"heroku/maven",
"heroku/nodejs",
"heroku/nodejs-corepack",
"heroku/nodejs-engine",
"heroku/nodejs-npm-engine",
"heroku/nodejs-npm-install",
"heroku/nodejs-pnpm-install",
"heroku/nodejs-yarn",
"heroku/php",
"heroku/procfile",
"heroku/python",
"heroku/ruby",
"heroku/sbt",
"heroku/scala",
},
}
Expand Down Expand Up @@ -131,9 +139,8 @@ func (a *AppJSON) GetBuilders() []string {
if a.Stack == "heroku-20" {
return []string{"heroku/buildpacks:20", "heroku/heroku:20-cnb"}
}
// TODO: use heroku/builder:22 can be used when all buildpacks are CNB
if a.Stack == "heroku-22" {
return []string{"heroku/builder-classic:22", "heroku/heroku:22-cnb"}
return []string{"heroku/builder:22", "heroku/heroku:22-cnb"}
}
return []string{a.Stack}
}
Expand Down

0 comments on commit 8f1bad6

Please sign in to comment.