fix: set __ActivateSuspended to not block xctest run by popup #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
approved these changes
Nov 11, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
## [2.7.25](v2.7.24...v2.7.25) (2024-11-11) ### Bug Fixes * set __ActivateSuspended to not block xctest run by popup ([#187](#187)) ([f45d58d](f45d58d))
|
🎉 This PR is included in version 2.7.25 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This usage itself improves Appium's launching WDA method for ios 16 and lower since Appium uses
xcrun devicectl device process launchfor ios 17+. I have locally tested at least this didn't break anything.(Inspired by danielpaulus/go-ios#510)
appium/appium#20270 for iOS 16 and lower should be improved. For iOS 17+, we need 3rd party such as go-ios. It looks like
xcrun devicectl device process launchdoesn't enable this.Maybe... we also could add trobleshooting guid about:
(from appium/appium#20270 (comment) ) to use this/go-ios later