fix: Consider transient overlay windows when respectSystemAlerts is enabled #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctive apps" This reverts commit eb5e7cb.
mwakizaka
force-pushed
the
fix/respect_half_modals
branch
from
dc629c3 to
00c4fa8
Compare
mwakizaka
changed the title
|
hm, GHA's macOS instances are taking longer time |
mykola-mokhnach
approved these changes
Oct 17, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
## [8.9.4](v8.9.3...v8.9.4) (2024-10-17) ### Bug Fixes * Consider transient overlay windows when respectSystemAlerts is enabled ([#946](#946)) ([f0bdce7](f0bdce7))
|
🎉 This PR is included in version 8.9.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hi @mwakizaka, congrats, the Appium project wants to compensate you for this contribution! Please reply to this comment mentioning me and sharing your OpenCollective account name, so that we can initiate payment! Or let me know if you decline to receive compensation via OpenCollective. Thank you! |
|
Hi @jlipps, thank you for your offer! Please use https://opencollective.com/masayuki-wakizaka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
XCUIElementTypeWindow type="XCUIElementTypeWindow" name="SBTransientOverlayWindow"no longer appears inapp-source-WDA_6.0.0.txt)The proposed change
What I confirmed
accessibility id=Sandboxaccessibility id=Sandboxafter update{"respectSystemAlerts":true}setting