Update router to latest version + minor fixes #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They should run in parallel (and with && you get serial running)
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Deploy Preview for spotify-showcase ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
patrick91
commented
Feb 27, 2024
Comment on lines
-7
to
-9
| # better safe than sorry | ||
| RUN chmod +x ./wait-for-it.sh && \ | ||
| chmod +x ./entrypoint.sh |
There was a problem hiding this comment.
this was throwing an error for me, and I don't think it is needed, so I removed it 😊
jerelmiller
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
This looks good from my end!
@michael-watson would you mind taking a look at this as well? I have less context on the router end of things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.