Add float16 support with configurable conversion behavior #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new dtype "<f2" for float16 with size 16 and Uint16Array as its array constructor. - Implemented `float16ToFloat32Array` method to convert Uint16Array (float16) to Float32Array. - Added static method `float16ToFloat32` for converting individual float16 values to float32. - Updated the `Parsed` type to handle float16 conversion when necessary. This update improves the handling of float16 data types in the npyjs library.
- Add `convertFloat16` constructor option to control float16 conversion behavior - Fix test data generation script to use correct paths - Update records.json format for better git diff visibility - Fix float16 test timeout issues - Ensure test data consistency between runs The `convertFloat16` option (defaults to true) allows users to: - true: automatically convert float16 to float32 (default) - false: keep raw uint16 values for custom handling
|
This is great — LOVE that it can be turned off configurably. Pulling down to test, and then I'll merge and deploy! |
|
Thank you again @eek — this is now on npm at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for NumPy's float16 data type with flexible handling options:
Key Features:
convertFloat16constructor option for configurable behaviortrue(default): auto-convert to float32 for ease of usefalse: keep raw uint16 values for custom handlingTechnical Details:
float16ToFloat32Arrayfor array conversionfloat16ToFloat32for single value conversionInfrastructure Improvements:
also updated the
README