fix: remove trailing proxy uri slash (#75)

Co-authored-by: AndreyBykov <[email protected]>
apify · May 31, 2022 · 5eda669 · 5eda669
1 parent f4e8407
commit 5eda669
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/launch-context.ts b/src/launch-context.ts
@@ -111,7 +111,17 @@ export class LaunchContext<
      * Use `undefined` to unset existing proxy URL.
      */
     set proxyUrl(url: string | undefined) {
-        this._proxyUrl = url && new URL(url).href;
+        if (!url) {
+            return;
+        }
+
+        const urlInstance = new URL(url);
+        urlInstance.pathname = '/';
+        urlInstance.search = '';
+        urlInstance.hash = '';
+
+        // https://www.chromium.org/developers/design-documents/network-settings/#command-line-options-for-proxy-settings
+        this._proxyUrl = urlInstance.href.slice(0, -1);
     }
 
     /**

diff --git a/test/browser-plugins/plugins.test.ts b/test/browser-plugins/plugins.test.ts
@@ -66,7 +66,7 @@ const runPluginTest = <
                 id,
                 launchOptions,
                 browserPlugin: plugin,
-                _proxyUrl: proxyUrl,
+                _proxyUrl: proxyUrl.slice(0, -1),
                 one: 1,
                 useIncognitoPages: false,
             };