-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support xrpc custom healthcheck methods #1
Conversation
@@ -27,6 +27,7 @@ jobs: | |||
run: | | |||
sudo cpanm --notest Test::Nginx > build.log 2>&1 || (cat build.log && exit 1) | |||
sudo luarocks install luacheck | |||
sudo luarocks install api7-lua-resty-http 0.2.2-0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'd better add xrpc
, it is meaningful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resty.http
is only used in testing.
After merging the PR here, the healthcheck library will be released and the xrpc suffix will be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By adding callback functions, custom health check methods can be applied to private protocols.