Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate "Creating Custom Doctrine ORM filters" heading in documentation #2085

Conversation

bumblecoder
Copy link
Contributor

Description:

This PR fixes a typo in the documentation where the "Creating Custom Doctrine ORM filters" heading is duplicated. The second heading, which links to the Elasticsearch filters documentation (https://api-platform.com/docs/core/elasticsearch-filters/#creating-custom-elasticsearch-filters), is incorrectly labeled as "Creating Custom Doctrine ORM filters."

Changes:

Updated the second duplicate heading to "Creating Custom Elasticsearch filters" for clarity and accuracy.

Why this change is needed:

The duplicate heading may confuse users, as the content under the second heading pertains to Elasticsearch filters rather than Doctrine ORM filters. Correcting this ensures the documentation is clear and easy to navigate.

Checklist:

  • Reviewed and verified changes locally
  • Confirmed that the link points to the correct documentation section

image

@bumblecoder
Copy link
Contributor Author

@vinceAmstoutz please review

Copy link
Contributor

@vinceAmstoutz vinceAmstoutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tanks @bumblecoder!

@vinceAmstoutz vinceAmstoutz merged commit 16f3445 into api-platform:4.0 Dec 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants