Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(laravel): Fixing BelongsToManyThrough #6862

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

amermchaudhary
Copy link
Contributor

Q A
Branch? 4.0
Tickets closes #6861
License MIT
Doc PR

@amermchaudhary amermchaudhary changed the title Fixing BelongsToMany feat(laravel): Fixing BelongsToManyThrough Dec 12, 2024
@soyuka
Copy link
Member

soyuka commented Dec 13, 2024

Would you be able to add a functional test?

You can add a fixture Model at:
https://github.com/api-platform/core/tree/main/src/Laravel/workbench

and a test inside: https://github.com/api-platform/core/blob/main/src/Laravel/Tests/GraphQlTest.php

Indeed, this would prevent any regression and it looks like this patch is quite important, thanks!

@soyuka soyuka merged commit 3a69462 into api-platform:4.0 Dec 19, 2024
58 of 59 checks passed
vinceAmstoutz pushed a commit to vinceAmstoutz/api-platform-core that referenced this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants