Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pagination): Add UuidRangeFilter to allow Uuid cursors #4689

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

KDederichs
Copy link
Contributor

Q A
Branch? main
Tickets api-platform/api-platform#2087
License MIT
Doc PR api-platform/docs#1520

As requested in #4595 I moved the Uuid Range to be its own thing.
I hope I managed to catch all the services that need to be wired if not let me know!

@Xusifob
Copy link

Xusifob commented Aug 16, 2022

Where is the status on this PR ? :)

@stale
Copy link

stale bot commented Nov 4, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 4, 2022
@nesl247
Copy link
Contributor

nesl247 commented Nov 4, 2022

This is still really needed.

@stale stale bot removed the wontfix label Nov 4, 2022
@stale
Copy link

stale bot commented Jan 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 3, 2023
@Xusifob
Copy link

Xusifob commented Jan 4, 2023

this is still needed

@stale stale bot removed the stale label Jan 4, 2023
@stale
Copy link

stale bot commented Mar 5, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 5, 2023
@Xusifob
Copy link

Xusifob commented Mar 6, 2023

This is still needed

@stale stale bot removed the stale label Mar 6, 2023
@nesl247
Copy link
Contributor

nesl247 commented Mar 20, 2023

What’s preventing this from being merged?

@stale
Copy link

stale bot commented May 19, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 19, 2023
@nesl247
Copy link
Contributor

nesl247 commented May 20, 2023

This is still needed.

@stale stale bot closed this May 27, 2023
@KDederichs
Copy link
Contributor Author

@soyuka
Since I ran into this yet again:
Should we re open this?

With the emergence and popularity of UUIDv7 this become rather relevant, at least if you try to do cursor based pagination with that.

@soyuka
Copy link
Member

soyuka commented Oct 28, 2023

#5618 has reasons why this still hasn't been merged...

@soyuka soyuka reopened this Oct 28, 2023
@stale stale bot removed the stale label Oct 28, 2023
# Conflicts:
#	.github/workflows/ci.yml
#	src/Doctrine/Common/Filter/RangeFilterTrait.php
#	src/Doctrine/Odm/Filter/RangeFilter.php
#	src/Doctrine/Orm/Filter/RangeFilter.php
#	tests/Fixtures/app/config/config_test.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants