Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-5564: Add nodets tests to Github Actions #3089

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cameron-martin
Copy link
Contributor

Client: nodets

This adds the tests for the "nodets" library. This isn't an actual library, and are just another set of tests for the nodejs library, but using typescript. Therefore I have added them in the existing "nodejs" job.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

Client: nodets

This adds the tests for the "nodets" library. This isn't an actual library, and are just another set of tests for the nodejs library, but also using typescript. Therefore I have added them in the existing "nodejs" job.
@cameron-martin
Copy link
Contributor Author

cc @jimexist, since it seems you have been working on the conversion to GitHub actions primarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant