Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

measured input stream #262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
* <p/>
* http://www.apache.org/licenses/LICENSE-2.0
* <p/>
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.tez.http;

import java.io.DataInputStream;
import java.io.IOException;

public class MeasuredDataInputStream extends DataInputStream {
private long elapsedTimeMs = 0;

public MeasuredDataInputStream(DataInputStream in) {
super(in);
}

@Override
public int read() throws IOException {
long start = System.currentTimeMillis();
int ret = super.read();
elapsedTimeMs += System.currentTimeMillis() - start;
return ret;
}

public long getElapsedTimeMs() {
return elapsedTimeMs;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
import org.apache.hadoop.io.WritableUtils;
import org.apache.tez.http.BaseHttpConnection;
import org.apache.tez.http.HttpConnectionParams;
import org.apache.tez.http.MeasuredDataInputStream;
import org.apache.tez.runtime.library.common.CompositeInputAttemptIdentifier;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand Down Expand Up @@ -563,7 +564,7 @@ private HostFetchResult setupConnection(Collection<InputAttemptIdentifier> attem

protected void setupConnectionInternal(String host, Collection<InputAttemptIdentifier> attempts)
throws IOException, InterruptedException {
input = httpConnection.getInputStream();
input = new MeasuredDataInputStream(httpConnection.getInputStream());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 for making it the default. Note that System.currentTimeMillis may turn out to be expensive when number of calls are higher. Especially in cloud nodes where hypervisors are involved.

Would suggest to make it optional.

Copy link
Contributor Author

@abstractdog abstractdog Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the input @rbalamohan, yes, absolutely, this is a work-in-progress patch, I was thinking about making it configurable too...working on that
I hope the basic idea makes sense to you: counting the time spent in InputStream.read to reflect the actual time spent with network traffic

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize that it was WIP patch. sure, +1 on the idea.

httpConnection.validate();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import org.apache.hadoop.io.WritableUtils;
import org.apache.tez.http.BaseHttpConnection;
import org.apache.tez.http.HttpConnectionParams;
import org.apache.tez.http.MeasuredDataInputStream;
import org.apache.tez.common.CallableWithNdc;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand Down Expand Up @@ -388,7 +389,7 @@ boolean setupConnection(MapHost host, Collection<InputAttemptIdentifier> attempt

protected void setupConnectionInternal(MapHost host, Collection<InputAttemptIdentifier> attempts)
throws IOException, InterruptedException {
input = httpConnection.getInputStream();
input = new MeasuredDataInputStream(httpConnection.getInputStream());
httpConnection.validate();
}

Expand Down