-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): loading viz_type from request params #31929
base: master
Are you sure you want to change the base?
Conversation
f2d6ea8
to
a8b5a39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a8b5a39
to
23f09f5
Compare
I was unable to post the issues I found. This could be because a force push or squash has changed the commit history since I scanned this pull request. You can get another review by commenting |
8ff4471
to
c9190ed
Compare
c9190ed
to
aa211c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but adding additional reviewers who might know better :)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #31929 +/- ##
==========================================
+ Coverage 60.48% 65.52% +5.03%
==========================================
Files 1931 546 -1385
Lines 76236 39292 -36944
Branches 8568 0 -8568
==========================================
- Hits 46114 25745 -20369
+ Misses 28017 13547 -14470
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SUMMARY
Previously, when passing
viz_type
via the API, it would default to table. This change allows us to send viz_type and have the charts respect it in the UITESTING INSTRUCTIONS
Make an API request via python and send the following params
The resulting chart would always be a table. No longer
ADDITIONAL INFORMATION