chore(config): remove deprecated AVOID_COLORS_COLLISION flag #31895
Conversation
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/dashboard/components/menu/BackgroundStyleDropdown.tsx | ✅ |
| superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts | ✅ |
| superset-frontend/packages/superset-ui-core/src/color/CategoricalColorScale.ts | ✅ |
| superset/config.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
| hooks: | ||
| - id: eslint | ||
| name: eslint | ||
| entry: bash -c 'cd superset-frontend && npm run eslint -- $(echo "$@" | sed "s|superset-frontend/||g")' |
There was a problem hiding this comment.
@mistercrunch this sed business seemed to be causing a lot of errors around missing files and whatnot. Is it a problem to remove it?
|
@geido the logic in the PR seems simple enough, but the tests failures worry me. Holler if you have time to look at them async or on zoom with me, and maybe we can sort it out. I'm hesitant to "make them pass" as I worry they point at some issue I've created or missed. |
|
/testenv up |
|
@rusackas Ephemeral environment spinning up at http://44.243.18.92:8080. Credentials are |
SUMMARY
Removing the previously deprecated AVOID_COLORS_COLLISION flag, and bring in its behavior full-time.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION