-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grouped ns lookup containers #441
grouped ns lookup containers #441
Conversation
Perhaps we could come up with a better name? |
I agree. I also thought about unifying all init container resources. But some start JVM processes, afaik. So this might not be a good approach. What do you think? |
I guess that in most cases there isn't a need to tune the init container resources and it's not a concern for most users. A configuration structure with a common setting could be simpler to adjust? |
3ebcd7e
to
d387fdc
Compare
@lhotari I merged all resources https://github.com/Mortom123/pulsar-helm-chart/actions/runs/7646614216 |
d387fdc
to
0951f18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
See #438 / #438 (comment) 1.PR
Motivation
rename init container resources to better reflect its actual use (nslookup)
Modifications
rename init container resources
Verifying this change