Skip to content

Commit

Permalink
Fix helm chart to allow configurable ingress pathType (#558)
Browse files Browse the repository at this point in the history
  • Loading branch information
rawmind0 authored Dec 11, 2024
1 parent 05c78df commit df9284d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/pulsar/templates/proxy-ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ spec:
servicePort: {{ .Values.proxy.ports.http }}
{{- end }}
{{- else }}
pathType: ImplementationSpecific
pathType: {{ .Values.proxy.ingress.pathType }}
backend:
service:
name: "{{ template "pulsar.fullname" . }}-{{ .Values.proxy.component }}"
Expand Down
2 changes: 1 addition & 1 deletion charts/pulsar/templates/pulsar-manager-ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ spec:
serviceName: "{{ template "pulsar.fullname" . }}-{{ .Values.pulsar_manager.component }}"
servicePort: {{ .Values.pulsar_manager.service.targetPort }}
{{- else }}
pathType: ImplementationSpecific
pathType: {{ .Values.pulsar_manager.ingress.pathType }}
backend:
service:
name: "{{ template "pulsar.fullname" . }}-{{ .Values.pulsar_manager.component }}"
Expand Down
2 changes: 2 additions & 0 deletions charts/pulsar/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1297,6 +1297,7 @@ proxy:

hostname: ""
path: "/"
pathType: ImplementationSpecific
## Proxy PodDisruptionBudget
## templates/proxy-pdb.yaml
##
Expand Down Expand Up @@ -1523,6 +1524,7 @@ pulsar_manager:

hostname: ""
path: "/"
pathType: ImplementationSpecific

## On first install, the helm chart tries to reuse an existing secret with matching name by default
## if this should fail it uses the given username and password to create a new secret
Expand Down

0 comments on commit df9284d

Please sign in to comment.