Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BROADCAST join strategy #14797

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jackie-Jiang
Copy link
Contributor

Add support for BROADCAST join strategy, where left table remains on the local server, and right table is broadcasted to the left table to perform the join.

E.g.

SELECT /*+ joinOptions(join_strategy = 'broadcast') */ a.col1, b.col2 FROM a JOIN b ON a.col1 = b.col1 WHERE a.col2 = 'foo' AND b.col2 = 'bar'

Related to #14518

@Jackie-Jiang Jackie-Jiang added feature release-notes Referenced by PRs that need attention when compiling the next release notes multi-stage Related to the multi-stage query engine labels Jan 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 63.88%. Comparing base (59551e4) to head (996e7a5).
Report is 1570 commits behind head on master.

Files with missing lines Patch % Lines
...pache/pinot/calcite/rel/hint/PinotHintOptions.java 80.00% 1 Missing ⚠️
...inot/query/planner/serde/PlanNodeDeserializer.java 0.00% 1 Missing ⚠️
.../pinot/query/planner/serde/PlanNodeSerializer.java 0.00% 1 Missing ⚠️
.../org/apache/pinot/query/routing/WorkerManager.java 88.88% 0 Missing and 1 partial ⚠️
...e/pinot/query/runtime/InStageStatsTreeBuilder.java 50.00% 0 Missing and 1 partial ⚠️
...he/pinot/query/runtime/plan/PlanNodeToOpChain.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14797      +/-   ##
============================================
+ Coverage     61.75%   63.88%   +2.13%     
- Complexity      207     1610    +1403     
============================================
  Files          2436     2704     +268     
  Lines        133233   150891   +17658     
  Branches      20636    23294    +2658     
============================================
+ Hits          82274    96399   +14125     
- Misses        44911    47273    +2362     
- Partials       6048     7219    +1171     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.80% <81.25%> (+2.09%) ⬆️
java-21 63.78% <81.25%> (+2.15%) ⬆️
skip-bytebuffers-false 63.84% <81.25%> (+2.09%) ⬆️
skip-bytebuffers-true 63.74% <81.25%> (+36.01%) ⬆️
temurin 63.88% <81.25%> (+2.13%) ⬆️
unittests 63.88% <81.25%> (+2.13%) ⬆️
unittests1 56.37% <81.25%> (+9.48%) ⬆️
unittests2 34.14% <0.00%> (+6.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature multi-stage Related to the multi-stage query engine release-notes Referenced by PRs that need attention when compiling the next release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants