Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-7126 Update apache parent pom version in QueryServer and bump… #141

Closed
wants to merge 1 commit into from

Conversation

NihalJain
Copy link
Contributor

… maven plugins/dependencies to latest

  • Bump apache parent pom version to 30
  • Remove maven-assembly-plugin-version as it is coming from parent pom
  • Bump following plugins:
    • maven-eclipse-plugin.version to 2.10
    • maven-build-helper-plugin.version to 3.5.0
    • spotbugs-maven-plugin.version to 4.8.1.0
    • spotbugs.version to 4.8.1
    • maven-owasp-plugin.version to 8.4.0
    • jacoco-maven-plugin.version to 0.8.11
    • maven-sonar-plugin.version to 3.10.0.2594
  • Fix scope of org.apache.phoenix:phoenix-queryserver scope to test as compilation fails otherwise with error "Non-test scoped test only dependencies found", possibly due to maven-dependency-plugin upgrade (via apache parent upgrade

… maven plugins/dependencies to latest

- Bump apache parent pom version to 30
- Remove maven-assembly-plugin-version as it is coming from parent pom
- Bump following plugins:
  - maven-eclipse-plugin.version to 2.10
  - maven-build-helper-plugin.version to 3.5.0
  - spotbugs-maven-plugin.version to 4.8.1.0
  - spotbugs.version to 4.8.1
  - maven-owasp-plugin.version to 8.4.0
  - jacoco-maven-plugin.version to 0.8.11
  - maven-sonar-plugin.version to 3.10.0.2594
 - Fix scope of org.apache.phoenix:phoenix-queryserver scope to test as compilation fails otherwise with error "Non-test scoped test only dependencies found", possibly due to maven-dependency-plugin upgrade (via apache parent upgrade
@NihalJain NihalJain marked this pull request as draft November 29, 2023 15:28
@NihalJain NihalJain marked this pull request as ready for review November 29, 2023 15:39
@NihalJain
Copy link
Contributor Author

Hi @stoty I even bumped other plugins which are not coming via apache parent and updated description. Please let me know if you want me to do that change separately and keep the scope to be just parent bump.

@stoty
Copy link
Contributor

stoty commented Nov 29, 2023

Your longer commit messages are always missing new lines, and I have to reformat them @NihalJain .
I don't know what breaks them.

@stoty stoty self-requested a review November 29, 2023 17:53
Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@NihalJain
Copy link
Contributor Author

NihalJain commented Nov 29, 2023

Your longer commit messages are always missing new lines, and I have to reformat them @NihalJain . I don't know what breaks them.

ohh i am very sorry for the trouble. Do you mean newline at the end of the commit description? Would you be able to share diff before and after reformat? to me it looks as newlines are there (So that I can avoid this mistake in future).

@stoty
Copy link
Contributor

stoty commented Nov 29, 2023

Not a major problem.
Just open this patch in patch format, and you will see:

https://patch-diff.githubusercontent.com/raw/apache/phoenix-queryserver/pull/141.patch

@stoty stoty closed this Nov 29, 2023
@NihalJain
Copy link
Contributor Author

Not a major problem. Just open this patch in patch format, and you will see:

https://patch-diff.githubusercontent.com/raw/apache/phoenix-queryserver/pull/141.patch

Thank you so much, this is very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants