PHOENIX-7091 Cleanup and ban log4j and related jars from phoenix-quer… #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-server - Add maven-enforcer-plugin and use it to ban commons-logging and other logging framework related jars - Remove all traces of log4j:log4j, org.slf4j:slf4j-log4j12 and commons-logging:commons-logging from dependency list - Replace log4j.properties with log4j2.properties (copied from hbase project) - Fix issue where IT logs where not getting logged in surefire reports due to "Failed to load class "org.slf4j.impl.StaticLoggerBinder" - See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details. - Fix log4j duplicate dependency warning in pom.xml
|
My bad, didnot fail locally as had a local 5.1.3 build with log4j remediated. Dropped patched jars from local repo. Will update PR with fix. |
|
Code is ready for review. Please review. Also, please let me know if banning jars seems too agressive (FYI HBase does the same). |
stoty
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y-server