Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHOENIX-7012 Expose keystore_type paramter in sqlline-thin.py #132

Closed
wants to merge 1 commit into from
Closed

PHOENIX-7012 Expose keystore_type paramter in sqlline-thin.py #132

wants to merge 1 commit into from

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Aug 3, 2023

No description provided.

richardantal
richardantal approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@richardantal richardantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoty stoty marked this pull request as draft August 8, 2023 06:02
@stoty
Copy link
Contributor Author

stoty commented Aug 8, 2023

Converted to draft.
We don't want to commit this until the included avatica version has the feature this uses.

@stoty stoty marked this pull request as ready for review February 27, 2024 16:34
@stoty
Copy link
Contributor Author

stoty commented Feb 27, 2024

merged manually.

@stoty stoty closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardantal richardantal richardantal approved these changes

@ss77892 ss77892 Awaiting requested review from ss77892

@ankitsinghal ankitsinghal Awaiting requested review from ankitsinghal

@chrajeshbabu chrajeshbabu Awaiting requested review from chrajeshbabu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stoty @richardantal