-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PARQUET-758: Add files with Float16 column #40
Conversation
apache/parquet-format#184 has now been merged, is this waiting on anything further? I'm mainly wondering what I should be doing with apache/arrow-rs#5003 |
data/README.md
Outdated
| float16_nonzeros_and_nans.parquet | Float16 (logical type) column with NaNs and nonzero finite min/max values | | ||
| float16_zeros_and_nans.parquet | Float16 (logical type) column with NaNs and zeros as min/max values | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you perhaps show how the file was generated, or how the data looks like, in the same spirit as was done for "NaN in stats" in below?
@benibus Can you please update this and make it ready for review? It would be better to merge this soon, so that the file can be used for integration testing in implementation PRs. |
@pitrou Extended the docs in the README and marked as ready to review. I believe these files should be sufficient for our purposes - including apache/arrow-rs#5003 (sorry about the wait, @tustvold... that was my bad). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @benibus !
These files are dependent on the Float16 type proposal's acceptance: apache/parquet-format#184
They should be useful for testing several cases across Parquet implementations:
Generated with:
Output: