Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NRFX to version 3.3 #3126

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Update NRFX to version 3.3 #3126

merged 6 commits into from
Jan 17, 2024

Conversation

kasjer
Copy link
Contributor

@kasjer kasjer commented Jan 10, 2024

NRFX change to vesion 3.3 required:

  • update of I2S due to multiply I2S peripheral instance support in (API changed)
  • pwm unused pin constant changed name
  • function to change pin assignment changed name
  • minor updates in nrfx_glue.h

@kasjer kasjer requested a review from sjanc January 10, 2024 08:04
nrfx_config.h file (plus nrfx_log.h and nrfx_config_common.h) were
taken verbatim from nrfx templates.

Other files were renamed to match nrfx convention.
All settings were preserved.

Signed-off-by: Jerzy Kasenberg <[email protected]>
- NRFX_PWM_PIN_NOT_USED change to NRF_PWM_PIN_NOT_CONNECTED.
- Pin inversion update to match NRFX.
- NRF91 now have syscfg values for PWM

Signed-off-by: Jerzy Kasenberg <[email protected]>
I2S driver was updated due to API change in version 3.3
Code seems to be able to support multiply instances of I2S peripherals.
NRFX_I2S_PIN_NOT_USED changed to NRF_I2S_PIN_NOT_CONNECTED.
I2S driver was updated due to API change in version 3.3
Code seems to be able to support multiply instances of I2S peripherals.
NRFX_I2S_PIN_NOT_USED changed to NRF_I2S_PIN_NOT_CONNECTED.

Error in microphone handling was also fixed (with change that is already
present in i2s_nrfx.c

Signed-off-by: Jerzy Kasenberg <[email protected]>
Now nrfx_config.h uses more specific selector for Nordic MCUs.
This adds definition NRF5xxxx_XXAA to all affected BSPs.
Definition NRF52/1 is still in place in case code other then NRFX
needs it.

Signed-off-by: Jerzy Kasenberg <[email protected]>
Copy link
Contributor

@rymanluk rymanluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rymanluk rymanluk merged commit 64e4e36 into apache:master Jan 17, 2024
16 checks passed
@kasjer kasjer deleted the kasjer/nrfx-3.2 branch January 17, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants