-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-17825: Update docs for ByteBufferDeserializer changes in 3.6 release #18466
base: trunk
Are you sure you want to change the base?
Conversation
…lease KIP-863 introduced a change to ByteBufferDeserializer which is not properly documented, but should be called out because it could surface bugs in application code which using ByteBufferDeserializer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just a minor comment
Co-authored-by: Lianet Magrans <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mjsax!
This is just a docs change, right? Seems pretty straightforward.
Co-authored-by: Kirk True <[email protected]>
Zookeeper clusters which are running binaries bundled with Kafka versions 2.4 or above can be updated directly.</li> | ||
<li><b><2.4</b> Kafka clusters first need to be updated to a version greater than 2.4 and smaller than 3.6. | ||
<li><b><2.4</b> Kafka clusters first need to be updated to a version greater than 2.4 and smaller than 3.6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side cleanup of broker html
@@ -656,9 +656,9 @@ <h5><a id="upgrade_360_notable" href="#upgrade_360_notable">Notable changes in 3 | |||
<li>The Apache Zookeeper dependency has been upgraded to 3.8.1 due to 3.6 reaching end-of-life. To bring both your | |||
Kafka and Zookeeper clusters to the latest versions: | |||
<ul> | |||
<li><b>>=2.4</b> Kafka clusters can be updated directly. | |||
<li><b>>=2.4</b> Kafka clusters can be updated directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side cleanup of broker html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except one minor nit.
clients/src/main/java/org/apache/kafka/common/serialization/Deserializer.java
Outdated
Show resolved
Hide resolved
…serializer.java Co-authored-by: Kirk True <[email protected]>
KIP-863 introduced a change to ByteBufferDeserializer which is not properly documented, but should be called out because it could surface bugs in application code which using ByteBufferDeserializer.