Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] fix(test): Fix flaky test CoordinatorServerTest#test #2332

Merged
merged 1 commit into from
Jan 9, 2025
Merged

[MINOR] fix(test): Fix flaky test CoordinatorServerTest#test #2332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 42 additions & 33 deletions coordinator/src/test/java/org/apache/uniffle/coordinator/CoordinatorServerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,43 +36,52 @@ public void test() throws Exception {

CoordinatorServer cs1 = new CoordinatorServer(coordinatorConf);
CoordinatorServer cs2 = new CoordinatorServer(coordinatorConf);
cs1.start();

ExitUtils.disableSystemExit();
String expectMessage = "Fail to start jetty http server";
final int expectStatus = 1;
CoordinatorServer cs3 = null;
try {
cs2.start();
} catch (Exception e) {
assertTrue(e.getMessage().startsWith(expectMessage));
assertEquals(expectStatus, ((ExitException) e).getStatus());
} finally {
// Always call stopServer after new CoordinatorServer to shut down ExecutorService
cs2.stopServer();
}
cs1.start();

coordinatorConf.setInteger("rss.jetty.http.port", 9529);
cs2 = new CoordinatorServer(coordinatorConf);
expectMessage = "Fail to start grpc server";
try {
cs2.start();
} catch (Exception e) {
assertEquals(expectMessage, e.getMessage());
assertEquals(expectStatus, ((ExitException) e).getStatus());
ExitUtils.disableSystemExit();
String expectMessage = "Fail to start jetty http server";
final int expectStatus = 1;
try {
cs2.start();
} catch (Exception e) {
assertTrue(e.getMessage().startsWith(expectMessage));
assertEquals(expectStatus, ((ExitException) e).getStatus());
} finally {
// Always call stopServer after new CoordinatorServer to shut down ExecutorService
cs2.stopServer();
}

coordinatorConf.setInteger("rss.jetty.http.port", 9529);
cs3 = new CoordinatorServer(coordinatorConf);
expectMessage = "Fail to start grpc server";
try {
cs3.start();
} catch (Exception e) {
assertEquals(expectMessage, e.getMessage());
assertEquals(expectStatus, ((ExitException) e).getStatus());
} finally {
// Always call stopServer after new CoordinatorServer to shut down ExecutorService
cs2.stopServer();
cs1.stopServer();
}

final Thread t =
new Thread(
null,
() -> {
throw new AssertionError("TestUncaughtException");
},
"testThread");
t.start();
t.join();
} finally {
// Always call stopServer after new CoordinatorServer to shut down ExecutorService
cs2.stopServer();
cs1.stopServer();
cs2.stopServer();
if (cs3 != null) {
cs3.stopServer();
}
}

final Thread t =
new Thread(
null,
() -> {
throw new AssertionError("TestUncaughtException");
},
"testThread");
t.start();
t.join();
}
}
Loading