[MINOR] improvement(spark-client): Refactor RssShuffleManager for spark2 and spark3 to reduce redundant code #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maobaolong
force-pushed
the
abstractRssShuffleManager
branch
2 times, most recently
from
127050e to
0fa7b2b
Compare
maobaolong
force-pushed
the
abstractRssShuffleManager
branch
2 times, most recently
from
26ff0a5 to
61cb95c
Compare
maobaolong
force-pushed
the
abstractRssShuffleManager
branch
from
61cb95c to
5a40312
Compare
jerqi
approved these changes
Jan 9, 2025
|
You are the committer. I can only rerun the failed test case. |
|
@jerqi Thanks for your tips. |
|
This has been tested on our test cluster for both spark v2 and v3 version client. merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor and abstract the same code into base class.
Why are the changes needed?
Reduce the redundant code and simplify the development in rss spark-client scope.
The Spark version unrelated code should be placed into RssShuffleManagerBase class, for this RssShuffleManager Class, it should only maintains the spark api related codes.
Does this PR introduce any user-facing change?
No.
How was this patch tested?