[VL] Enable remaining passed 3.5 UT #5494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
gaoyangxiaozhu
changed the title
|
Thank you! @gaoyangxiaozhu . @yma11 Can you confirm? |
Hi @FelixYBW these are the failures happens in the ones we copied from Spark3.4. The gaps are not filled yet. I will add those suites and list out the failed ones late. |
|
Run Gluten Clickhouse CI |
|
It's just already fixed. Rebase your PR please. |
|
Run Gluten Clickhouse CI |
|
hey @zhouyuan / @zhli1142015 / @yma11 can you help sign ? |
ping again |
yma11
approved these changes
Apr 25, 2024
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
Preetesh2110
pushed a commit
to Preetesh2110/incubator-gluten
that referenced
this pull request
Apr 25, 2024
3 uts should be the only remaning UTs not been enabled for spark 3.5 comparing with 3.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
@FelixYBW / @zhouyuan / @yma11 I do a global search with keyworkd
disable for spark3.5, those 3 uts should be the only remaning UTs not been enabled for spark 3.5 comparing with 3.4, after this PR is merged, all UT withdisabled for spark3.5should be covered and enabled, exceptHive compatibility check for get_json_objectwith is address by this PR #5467(Fixes: #5341)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)