Skip to content

Commit

Permalink
insert a build step
Browse files Browse the repository at this point in the history
  • Loading branch information
wgtmac committed Dec 31, 2024
1 parent e171cab commit d6dceae
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 17 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/cpp-linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ jobs:
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- name: Run build
run: |
mkdir build && cd build
cmake .. -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
cmake --build .
- uses: cpp-linter/[email protected]
id: linter
continue-on-error: true
Expand All @@ -43,8 +48,7 @@ jobs:
lines-changed-only: true
thread-comments: true
ignore: 'build|cmake_modules|ci'
database: build/compile_commands.json
extra-args: '-std=c++20 -Wall'
database: build
- name: Fail fast?!
if: steps.linter.outputs.checks-failed != 0
run: |
Expand Down
21 changes: 6 additions & 15 deletions api/iceberg/table.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,24 +20,15 @@
#pragma once

#include <memory>



#include <string_view>
#include <string_view>

namespace iceberg {

class Table {
public:
virtual ~Table( ) = default;

virtual std::string_view print() const = 0;


static std::unique_ptr<Table> create();

private:
int SOME_ID = 1;
class Table {
public:
virtual ~Table() = default;
virtual std::string_view print() const = 0;
static std::unique_ptr<Table> create();
};

} // namespace iceberg

0 comments on commit d6dceae

Please sign in to comment.