Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34113] Update flink-connector-elasticsearch to be compatible with updated SinkV2 interfaces #88

Closed
wants to merge 2 commits into from

Conversation

Jiabao-Sun
Copy link
Contributor

[FLINK-34113] Update flink-connector-elasticsearch to be compatible with updated SinkV2 interfaces

We can use TestSinkInitContext instead of MockInitContext to resolve this compilation problem.

Copy link

boring-cyborg bot commented Jan 26, 2024

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

@Jiabao-Sun Jiabao-Sun force-pushed the FLINK-34113 branch 2 times, most recently from c8da2cc to 0b7eabb Compare January 26, 2024 08:17
pom.xml Outdated
<groupId>org.yaml</groupId>
<artifactId>snakeyaml</artifactId>
<version>1.31</version>
</dependency>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jiabao-Sun
Copy link
Contributor Author

Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jiabao-Sun Thanks for this, but then we also need to make sure that this is tested against 1.19-SNAPSHOT if I'm not mistaken. Can you add that to this PR, so we can see if everything will compile against 1.17, 1.18 and 1.19, or what we need to drop?

@Jiabao-Sun
Copy link
Contributor Author

@Jiabao-Sun Thanks for this, but then we also need to make sure that this is tested against 1.19-SNAPSHOT if I'm not mistaken. Can you add that to this PR, so we can see if everything will compile against 1.17, 1.18 and 1.19, or what we need to drop?

Hey @MartijnVisser, this PR can be tested against 1.19-SNAPSHOT as well.

image

Copy link

@WencongLiu WencongLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only left a single comment.

pom.xml Outdated
@@ -339,6 +339,13 @@ under the License.
<version>2.1</version>
</dependency>

<!-- For dependency convergence -->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be placed to a seperate commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WencongLiu for the review.
I have split it into a hotfix commit.
Please help look it again.

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jiabao-Sun for the update, LGTM

Copy link

@WencongLiu WencongLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot @Jiabao-Sun !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants