Add sqlite sqllogictest run to extended.yml #14101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uite against every push to main.
github-actions
bot
added
the
development-process
comphead
reviewed
Jan 14, 2025
| @@ -15,7 +15,7 @@ | |||
| # specific language governing permissions and limitations | |||
| # under the License. | |||
|
|
|||
| name: Rust Hash Collisions | |||
| name: Datafusion extended tests | |||
There was a problem hiding this comment.
perhaps we can rename it like
Tests when hash values collide
There was a problem hiding this comment.
That field is for the name of the workflow, not the job within it. Now that the workflow covers both hash and sqlite tests I thought it should be just a generic name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13967
Rationale for this change
Run sqlite test suite on push to main.
## What changes are included in this PR?
Just the github action.
Are these changes tested?
No, I do not know of a great way to test this.
Are there any user-facing changes?
No.
NOTE: This PR should NOT be merged until apache/datafusion-testing#4 is merged into datafusion-testing and datafusion repo has been updated with a reference to that commit. As well a manual run of the sqlite test suite should likely be done prior to merging this just in case a change crept in between the generation of the sqlite test files and the merging of this PR.