Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on array_distinct when input is empty #13810 #14034

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Fix error on array_distinct when input is empty #13810 #14034

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b73cab0
fix
cht42 Jan 7, 2025
268dd67
add test
cht42 Jan 8, 2025
f26a911
oops
cht42 Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions datafusion/functions-nested/src/set_ops.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,9 +513,6 @@ fn general_array_distinct<OffsetSize: OffsetSizeTrait>(
array: &GenericListArray<OffsetSize>,
field: &FieldRef,
) -> Result<ArrayRef> {
if array.len() == 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need to remove this check? 🤔 it prevents unnecessary work/allocations if nothing is in the array

return Ok(Arc::new(array.clone()) as ArrayRef);
}
let dt = array.value_type();
let mut offsets = Vec::with_capacity(array.len());
offsets.push(OffsetSize::usize_as(0));
Expand All @@ -542,6 +539,9 @@ fn general_array_distinct<OffsetSize: OffsetSizeTrait>(
};
new_arrays.push(array);
}
if new_arrays.is_empty() {
return Ok(Arc::new(array.clone()) as ArrayRef);
}
let offsets = OffsetBuffer::new(offsets.into());
let new_arrays_ref = new_arrays.iter().map(|v| v.as_ref()).collect::<Vec<_>>();
let values = compute::concat(&new_arrays_ref)?;
Expand Down
Loading