-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add boolean column to aggregate queries for fuzz testing #13331
Conversation
test-utils/src/array_gen/boolean.rs
Outdated
use rand::rngs::StdRng; | ||
use rand::Rng; | ||
|
||
/// Randomly generate decimal arrays |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here.
decimal -> boolean
Thank you @jonathanc-n -- I am sorry for the delay in reviewing. I have been away for a few days but am back now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me -- thank you @jonathanc-n and @LeslieKid for the review
pub fn gen_data<D>(&mut self) -> ArrayRef { | ||
// Table of booleans from which to draw (distinct means 1 or 2) | ||
let distinct_booleans: BooleanArray = match self.num_distinct_booleans { | ||
1 => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…e#13331) * add bool col * clippy fix * remove change * fmt fix * typo fix
Which issue does this PR close?
Closes #13297 .
Rationale for this change
Want boolean column for aggregate fuzz testing.
What changes are included in this PR?
Added boolean array generator as booleans are regarded as a special type among arrow types due to bit packing. It also gives the option of having either one type of boolean or two.
Are these changes tested?
Might have tests for generators in future.