Introduce HashMap and HashSet type aliases #13236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
drauschenbach
force-pushed
the
hashmap-type-alias
branch
from
6e1c61c to
2a37800
Compare
Dandandan
reviewed
Nov 3, 2024
| collections::{HashMap, HashSet}, | ||
| sync::Arc, | ||
| }; | ||
| use std::{collections::HashSet, sync::Arc}; |
There was a problem hiding this comment.
Maybe you could do the same to HashSet?
drauschenbach
changed the title
Dandandan
approved these changes
Nov 4, 2024
Dandandan
approved these changes
Nov 4, 2024
andygrove
approved these changes
Nov 5, 2024
|
Thank you @drauschenbach |
findepi
pushed a commit
to sdf-labs/arrow-datafusion
that referenced
this pull request
Nov 25, 2024
* Unite all references to hashbrown::HashMap by using a common type definition * Replace some use of std::collections::HashMap with hashbrown::HashMap * Replace some use of std::collections::HashMap with hashbrown::HashMap * Replace some use of std::collections::HashMap with hashbrown::HashMap * Unite all references to hashbrown::HashSet by using a common type definition * Replace some use of std::collections::HashSet with hashbrown::HashSet
findepi
pushed a commit
to sdf-labs/arrow-datafusion
that referenced
this pull request
Nov 26, 2024
* Unite all references to hashbrown::HashMap by using a common type definition * Replace some use of std::collections::HashMap with hashbrown::HashMap * Replace some use of std::collections::HashMap with hashbrown::HashMap * Replace some use of std::collections::HashMap with hashbrown::HashMap * Unite all references to hashbrown::HashSet by using a common type definition * Replace some use of std::collections::HashSet with hashbrown::HashSet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #677.
Rationale for this change
Centralize the recommended default implementation of
HashMapandHashSet.What changes are included in this PR?
hashbrown::HashMapare now unified under thedatafusion_common::HashMaptype alias.hashbrown::HashSetare now unified under thedatafusion_common::HashSettype alias.std::collections::HashMapandstd::collections::HashSetare replaced with the type alias, where public contracts were not involved, and where tests did not break.Are these changes tested?
Yes, on an Apple M1.
Are there any user-facing changes?
Hopefully not. All tests and public contracts are left untouched, where
std::collections::types are the idiomatic platform default.