Convert LexOrdering type to struct.
#13146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
ngli-me
force-pushed
the
feature/lex-ordering-request-struct
branch
from
7ba63c3 to
bf53894
Compare
added 3 commits
October 28, 2024 20:38
… `unwrap_or` to `unwrap_or_default`.
…LexOrdering and LexOrderingRef.
ngli-me
changed the title
types to structs.
ngli-me
changed the title
types to structs.type to struct.
|
I initially also converted |
berkaysynnada
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
LGTM, thank you @ngli-me. Just have a few minor suggestions
datafusion/core/src/datasource/physical_plan/file_scan_config.rs
Outdated
Show resolved
Hide resolved
ngli-me
force-pushed
the
feature/lex-ordering-request-struct
branch
from
335339a to
e99e386
Compare
alamb
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
This is amazing -- thank you @ngli-me and @berkaysynnada
I think we can make it even better and remove LexOrderingRef in favor of &LexOrdering but we can do so as a follow on PR.
I am exploring how to do this
This was referenced Oct 31, 2024
|
Thank you again @ngli-me and @berkaysynnada I filed some follow on work:
I also double checked that when I merged this branch up to main it still passed all its tests |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12591.
Rationale for this change
What changes are included in this PR?
Adds
LexOrderingas a struct, instead of a type.Replaces previous occurrences of
LexOrderingof thetypewithstructwhere appropriate.Replaces
&[PhysicalSortExpr]with the typeLexOrderingRef, where appropriate.Aligns printing for
LexOrdering, since some instances of aPhysicalSortExprwere being printed with,, and others with,. Changed printing over to the latter, since this seems to align more with other instances of printing multiple items.Are these changes tested?
Yes, adjusted tests where necessary.
Are there any user-facing changes?
The Vec needs to be wrapped to initialize the struct instance, and some of the usage needs to be adjusted to get the field from the struct.