Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically run sqlitetests regularly (but not with all PRs) to DataFusion #13967

Open
Tracked by #13811
alamb opened this issue Jan 1, 2025 · 3 comments · May be fixed by #14101
Open
Tracked by #13811

Automatically run sqlitetests regularly (but not with all PRs) to DataFusion #13967

alamb opened this issue Jan 1, 2025 · 3 comments · May be fixed by #14101
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Jan 1, 2025

Is your feature request related to a problem or challenge?

However, at the moment it is only run manually and thus may start to fail without anyone knowing

Describe the solution you'd like

I would like to:

  1. Run the test regularly (perhaps on each commit to main)
  2. Make it clear what to do if the test fails

Describe alternatives you've considered

I would personally suggest adding a new workflow in

https://github.com/apache/datafusion/tree/main/.github/workflows

For example "extended.yml"

that only runs on each commit to main

Following the instructions here: https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest#running-tests-sqlite
(aka I suggest using release-nonlto mode)

The job should make it clear what is going on if it fails -- aka add a comment like this that point people to the sqlogictest instructions:

# if you encounter error, rerun the command below and commit the changes
#
# ignore subproject CHANGELOG.md because they are machine generated

Additional context

No response

@Omega359
Copy link
Contributor

Omega359 commented Jan 1, 2025

Right now the tests will fail all the time so I'm not sure this is a good idea until we either fix all the failures or mark them as skipif Datafusion with an associated issue #.

@Omega359
Copy link
Contributor

Omega359 commented Jan 1, 2025

Filed #13972 for resolving sqlite test failures.

@Omega359 Omega359 linked a pull request Jan 12, 2025 that will close this issue
@Omega359
Copy link
Contributor

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants