Skip to content

Commit

Permalink
fix comment about min stack requirement
Browse files Browse the repository at this point in the history
  • Loading branch information
peter-toth committed Nov 11, 2024
1 parent 5659520 commit 17319c2
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions datafusion/sql/src/query.rs
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,9 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
self.select_into(plan, select_into)
}
other => {
// TODO: check why set_expr_to_plan or the functions it calls need bigger
// minimum stack
// The functions called from `set_expr_to_plan()` need more than 128KB
// stack in debug builds as investigated in:
// https://github.com/apache/datafusion/pull/13310#discussion_r1836813902
let min_stack_size = recursive::get_minimum_stack_size();
recursive::set_minimum_stack_size(256 * 1024);
let plan = self.set_expr_to_plan(other, planner_context)?;
Expand Down

0 comments on commit 17319c2

Please sign in to comment.