-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXP][C++] Deduplicate schemas when scanning Dataset #45340
base: main
Are you sure you want to change the base?
Conversation
@ursabot please benchmark |
Benchmark runs are scheduled for commit f681035. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete. |
9610573
to
a0503f3
Compare
@ursabot please benchmark |
Benchmark runs are scheduled for commit a0503f3. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete. |
@icexelloss This is a quick experiment that you might want to try out on a real-world use case. I don't seem to get any tangible benefits on a synthetic dataset, though it might be due to memory fragmentation. |
Thanks for your patience. Conbench analyzed the 0 benchmarking runs that have been run so far on PR commit f681035. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
Thanks for your patience. Conbench analyzed the 4 benchmarking runs that have been run so far on PR commit a0503f3. There were 775 benchmark results indicating a performance regression:
The full Conbench report has more details. |
Ok, there are so many unrelated "regressions" in the report above that I'm going to launch another benchmarking run, as it's likely that external factors have influenced that run. |
@ursabot please benchmark |
Commit a0503f3 already has scheduled benchmark runs. |
a0503f3
to
335a46b
Compare
@ursabot please benchmark |
Benchmark runs are scheduled for commit 335a46b. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete. |
Thanks for your patience. Conbench analyzed the 4 benchmarking runs that have been run so far on PR commit 335a46b. There were 23 benchmark results indicating a performance regression:
The full Conbench report has more details. |
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?