-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45237: [Python] Raise minimum supported cython to >=3 #45238
Conversation
|
… should not be required anymore
@github-actions crossbow submit -g python |
Revision: c6bf8d4 Submitted crossbow builds: ursacomputing/crossbow @ actions-07fd1dc2a0 |
…This pin should not be required anymore" This reverts commit 0158ad5.
I tried to remove the |
@github-actions crossbow submit test-conda-python-3.11-hypothesis |
Revision: 2889c63 Submitted crossbow builds: ursacomputing/crossbow @ actions-6811b48c94
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I think we can also remove this line:
Lines 203 to 205 in 04249b9
# See https://github.com/cython/cython/issues/2731. Change introduced in | |
# Cython 0.29.1 causes "unsafe use of type 'bool' in operation" | |
string(APPEND CMAKE_CXX_FLAGS " /wd4804") |
There are also some other snippets in the cython code that we keep around only for cython 2 compat, I think, but that probably can be removed later as well (for example our custom declaration of |
@github-actions crossbow submit -g python |
@jorisvandenbossche I've removed the unnecessary To tackle the |
Revision: 87bd74f Submitted crossbow builds: ursacomputing/crossbow @ actions-20576e4f2d |
@github-actions crossbow submit wheel-windows-cp310-cp310-amd64 |
Revision: 87bd74f Submitted crossbow builds: ursacomputing/crossbow @ actions-3c1d7348b5
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 8d367d2. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
We do not require to support Cython 2 anymore.
What changes are included in this PR?
Bump required version of Cython
Are these changes tested?
Via CI
Are there any user-facing changes?
Yes, pyarrow cannot be compiled with Cython2 anymore.