Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45219: [C++][Examples] Update examples to disable mimalloc #45220

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

zanmato1984
Copy link
Contributor

@zanmato1984 zanmato1984 commented Jan 10, 2025

Rationale for this change

I think the intention was to disable the default allocator which used to be jemalloc. However since #44951 we have switched the default allocator from jemalloc to mimalloc. We should update the examples.

What changes are included in this PR?

Change disabling jemalloc to disabling mimalloc for examples.

Are these changes tested?

Manually tested.

Are there any user-facing changes?

None.

Copy link

⚠️ GitHub issue #45219 has been automatically assigned in GitHub to PR creator.

@zanmato1984
Copy link
Contributor Author

Hi @kou @pitrou , do you think this makes sense? Thanks.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jan 10, 2025
@zanmato1984
Copy link
Contributor Author

@github-actions crossbow submit example-cpp

Copy link

Unable to match any tasks for `example-cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/12703786703

@zanmato1984
Copy link
Contributor Author

@github-actions crossbow submit example-cpp-tutorial

Copy link

Revision: bef1294

Submitted crossbow builds: ursacomputing/crossbow @ actions-0e4ff4c147

Task Status
example-cpp-tutorial GitHub Actions

@zanmato1984 zanmato1984 merged commit b740382 into apache:main Jan 10, 2025
32 of 34 checks passed
@zanmato1984 zanmato1984 removed the awaiting merge Awaiting merge label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants