Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44563: [C++] FunctionOptions::{Serialize,Deserialize}() return an error without ARROW_IPC #45171

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

kou
Copy link
Member

@kou kou commented Jan 4, 2025

Rationale for this change

They use IPC format internally. So we can't do them without ARROW_IPC.

What changes are included in this PR?

Returns arrow::Status::NotImplemented without ARROW_IPC.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

…rn an error without ARROW_IPC

It uses IPC format internally. So we can't do them without ARROW_IPC.
@kou
Copy link
Member Author

kou commented Jan 4, 2025

We don't need to update our tests because ARROW_BUILD_TESTS enables ARROW_IPC implicitly:

define_option(ARROW_BUILD_TESTS
"Build the Arrow googletest unit tests"
OFF
DEPENDS
ARROW_IPC
ARROW_TESTING)

@kou
Copy link
Member Author

kou commented Jan 6, 2025

I'll merge this tomorrow for 19.0.0 if nobody objects this.

@kou
Copy link
Member Author

kou commented Jan 6, 2025

Thanks for approval. I'll merge this now.

@kou kou merged commit ada8750 into apache:main Jan 6, 2025
35 of 38 checks passed
@kou kou deleted the cpp-compute-ipc branch January 6, 2025 05:39
@kou kou removed the awaiting committer review Awaiting committer review label Jan 6, 2025
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ada8750.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants