Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-45166: [CI][C++] Upgrade Alpine Linux to 3.18 from 3.16 #45168

Merged
merged 4 commits into from
Jan 7, 2025
Merged

GH-45166: [CI][C++] Upgrade Alpine Linux to 3.18 from 3.16 #45168

merged 4 commits into from
Jan 7, 2025

Conversation

kou
Copy link
Member

@kou kou commented Jan 4, 2025 •
edited by github-actions bot
Loading

Rationale for this change

Alpine Linux 3.16 reached EOL.

What changes are included in this PR?

Use Alpine Linux 3.18 that is the oldest maintained version.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025

⚠️ GitHub issue #45166 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member Author

kou commented Jan 4, 2025

@github-actions crossbow submit test-alpine-linux-cpp

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@kou
Copy link
Member Author

kou commented Jan 4, 2025

@github-actions crossbow submit test-alpine-linux-cpp

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@kou
Copy link
Member Author

kou commented Jan 4, 2025

@github-actions crossbow submit test-alpine-linux-cpp

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@kou
Copy link
Member Author

kou commented Jan 5, 2025

@github-actions crossbow submit -g cpp

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@kou
Copy link
Member Author

kou commented Jan 6, 2025

I'll merge this tomorrow for 19.0.0 if nobody objects this.

pitrou
pitrou reviewed Jan 6, 2025
View reviewed changes
cpp/cmake_modules/ThirdpartyToolchain.cmake Outdated
@@ -1329,6 +1337,19 @@ if(ARROW_USE_BOOST)
endif()
if(Boost_VERSION VERSION_GREATER_EQUAL 1.80)
target_compile_definitions(Boost::process INTERFACE "BOOST_PROCESS_HAVE_V2")
if((NOT WIN32) AND (NOT ARROW_WITH_MUSL))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of repeating this, can we factor it out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about 209c60d ?

@kou
Copy link
Member Author

kou commented Jan 6, 2025

@github-actions crossbow submit -g cpp

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

Revision: 209c60d

Submitted crossbow builds: ursacomputing/crossbow @ actions-313055b85e

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp-ubuntu-20.04-cuda-11.2.2 GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-ubuntu-20.04-cpp GitHub Actions
test-ubuntu-20.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jan 6, 2025
@assignUser assignUser mentioned this pull request Jan 7, 2025
Closed
@assignUser assignUser merged commit f41f590 into apache:main Jan 7, 2025
40 of 42 checks passed
@assignUser assignUser removed the awaiting changes Awaiting changes label Jan 7, 2025
@assignUser assignUser mentioned this pull request Jan 7, 2025
Closed
@kou kou deleted the ci-alpine-3.18 branch January 7, 2025 02:28
@conbench-apache-arrow conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit f41f590.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou left review comments

@assignUser assignUser assignUser approved these changes

@jonkeane jonkeane Awaiting requested review from jonkeane jonkeane is a code owner

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

Assignees
No one assigned
Labels
Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kou @pitrou @assignUser