Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add a gcc 15 CI job #44970

Closed
wants to merge 9 commits into from
Closed

[WIP] Add a gcc 15 CI job #44970

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b3d1413
Add a gcc 15 job
jonkeane Dec 9, 2024
bd4d541
try snapshot
jonkeane Dec 9, 2024
a3d5e63
no g++ snapshot
jonkeane Dec 9, 2024
d7ee6f7
try snapshot
jonkeane Dec 9, 2024
8f235bd
this?
jonkeane Dec 10, 2024
7fa1d13
ugh
jonkeane Dec 10, 2024
3bd2d90
ugh
jonkeane Dec 10, 2024
9f2d327
Kou's comments
jonkeane Dec 29, 2024
695213a
a little less dry
jonkeane Dec 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ci/docker/ubuntu-24.04-cpp.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,14 @@ RUN if [ "${gcc_version}" = "" ]; then \
add-apt-repository ppa:ubuntu-toolchain-r/volatile; \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use ppa:ubuntu-toolchain-r/ppa ( https://launchpad.net/~ubuntu-toolchain-r/+archive/ubuntu/ppa ) instead?
It seems that this doesn't have gcc-14 nor gcc-15: https://launchpad.net/~ubuntu-toolchain-r/+archive/ubuntu/volatile

https://launchpad.net/~ubuntu-toolchain-r/+archive/ubuntu/volatile has gcc-15 but it's for Ubuntu 25.04.

It may be better that we use Debian GNU/Linux experimental instead: https://packages.debian.org/search?keywords=gcc-15
If Debian GNU/Linux experimental is OK, I can work on it.

fi; \
apt-get update -y -q && \
apt-get install -y -q --no-install-recommends \
if [ "${gcc_version}" == "snapshot" ]; then \
apt-get install -y -q --no-install-recommends \
gcc-${gcc_version} && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use ; not && here.

else \
apt-get install -y -q --no-install-recommends \
g++-${gcc_version} \
gcc-${gcc_version} && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use ; not && here.

fi; \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use & not ; here.

update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-${gcc_version} 100 && \
update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-${gcc_version} 100 && \
update-alternatives --install \
Expand Down
12 changes: 12 additions & 0 deletions dev/tasks/tasks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,6 +962,18 @@ tasks:
flags: -e CC=gcc-14 -e CXX=g++-14 -e RapidJSON_SOURCE=BUNDLED
image: ubuntu-cpp

test-ubuntu-24.04-cpp-gcc-15:
ci: github
template: docker-tests/github.linux.yml
params:
env:
CLANG_TOOLS: 15
GCC_VERSION: snapshot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'm not sure what this is supposed to mean, but FTR we would only like to test against a released gcc version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to get a CI job up that tests what CRAN is testing at https://www.stats.ox.ac.uk/pub/bdr/gcc15/arrow.out Which, is indeed the unreleased GCC. I haven't (yet) gotten an email asking us to fix this, but we have in the past been asked to fix things that error on even unreleased compilers. (Yes, I know this sounds absurd, nevertheless it's the way CRAN works).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't need to even run it nightly (CRAN does that for us to an extent), but having something that lets us check and confirm if our fix worked would be lovely.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can have nightly CI jobs for unreleased GCC (and LLVM) to support them in a timely manner.
For example, Homebrew sometimes backports the latest LLVM support patch: Homebrew/homebrew-core@13bceca#diff-34b98d9d12bbe5d68aaf6c2fc936056651d4c8b8aeaf7612e1ba508a0077d8ffR16

LLVM: 15
UBUNTU: 24.04
flags: -e CC=gcc-snapshot -e CXX=g++-snapshot -e RapidJSON_SOURCE=BUNDLED
image: ubuntu-cpp

test-skyhook-integration:
ci: github
template: docker-tests/github.linux.yml
Expand Down
Loading