Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Proof-of-concept Parquet GEOMETRY logical type implementation #43196

Closed
wants to merge 29 commits into from
Closed

WIP: Proof-of-concept Parquet GEOMETRY logical type implementation #43196

Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
4a4ebc9
update thrift
paleolimbot Jun 29, 2024
6f4e4b7
update thrift defs
paleolimbot Jun 29, 2024
6acb2f2
add stubs
paleolimbot Jun 30, 2024
6ff5855
split methods out of line
paleolimbot Jun 30, 2024
0ac5d84
maybe to/from thrift
paleolimbot Jul 9, 2024
8a80ac7
a few more serializers
paleolimbot Jul 9, 2024
f330997
add basic test for serialization
paleolimbot Aug 7, 2024
b34b1c2
add sort order check
paleolimbot Aug 7, 2024
7e9f9b2
update thrift
paleolimbot Aug 12, 2024
6a9ac3a
start geom utiles
paleolimbot Aug 12, 2024
a22908f
test roundtrip thrift cases
paleolimbot Aug 14, 2024
dcc083a
more geometry utils
paleolimbot Aug 14, 2024
9acc840
more
paleolimbot Aug 14, 2024
e18412c
bounder
paleolimbot Aug 14, 2024
76b3f59
add basic test
paleolimbot Aug 14, 2024
fc77ff2
a few more strings
paleolimbot Aug 14, 2024
21f11a1
test some bounding box things
paleolimbot Aug 14, 2024
6bbce5c
more tests
paleolimbot Aug 14, 2024
bb41b06
fix test
paleolimbot Aug 14, 2024
88a42f5
with passing tests
paleolimbot Aug 14, 2024
3798ef1
add in WKT equiv
paleolimbot Aug 14, 2024
ccbd616
more tests
paleolimbot Aug 14, 2024
3752f83
start on stats
paleolimbot Aug 17, 2024
2ff6078
implement update/merge for geometry statistics
paleolimbot Aug 19, 2024
79e4715
more complete stats
paleolimbot Aug 19, 2024
4444757
start on factory methods
paleolimbot Aug 19, 2024
176c997
more stats things
paleolimbot Aug 19, 2024
1de193e
maybe work with serde
paleolimbot Aug 19, 2024
d2f8157
Update cpp/src/parquet/types.cc
paleolimbot Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2,528 changes: 1,487 additions & 1,041 deletions cpp/src/generated/parquet_types.cpp
View file
Open in desktop

Large diffs are not rendered by default.

664 changes: 569 additions & 95 deletions cpp/src/generated/parquet_types.h
View file
Open in desktop

Large diffs are not rendered by default.

1,006 changes: 770 additions & 236 deletions cpp/src/generated/parquet_types.tcc
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions cpp/src/parquet/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,8 @@ add_parquet_test(internals-test
public_api_test.cc
types_test.cc)

add_parquet_test(geometry-test SOURCES geometry_util_test.cc)

set_source_files_properties(public_api_test.cc PROPERTIES SKIP_PRECOMPILE_HEADERS ON
SKIP_UNITY_BUILD_INCLUSION ON)

Expand Down
Loading
Loading